Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LTL] Deprecate disable intrinsic #4237

Merged
merged 2 commits into from
Jul 2, 2024
Merged

[LTL] Deprecate disable intrinsic #4237

merged 2 commits into from
Jul 2, 2024

Conversation

dobios
Copy link
Member

@dobios dobios commented Jul 2, 2024 •
edited by jackkoenig
Loading

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API deprecation

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

jackkoenig
jackkoenig approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but with messages (I'll commit the suggestions)

src/main/scala/chisel3/ltl/LTL.scala Outdated Show resolved Hide resolved
src/main/scala/chisel3/ltl/LTL.scala Outdated Show resolved Hide resolved
@jackkoenig jackkoenig added the Deprecation Deprecates an API, will be included in release notes label Jul 2, 2024
@jackkoenig jackkoenig added this to the 6.x milestone Jul 2, 2024
@jackkoenig jackkoenig enabled auto-merge (squash) July 2, 2024 00:55
@jackkoenig
Copy link
Contributor

Note there's no reason to include the title in the Release Notes as the title will be included automatically (in addition to anything under Release Notes).

@jackkoenig jackkoenig merged commit 9c61fdc into chipsalliance:main Jul 2, 2024
15 checks passed
@mergify mergify bot added the Backported This PR has been backported label Jul 2, 2024
mergify bot pushed a commit that referenced this pull request Jul 2, 2024
@dobios @mergify
[LTL] Deprecate disable intrinsic (#4237)
f01a603 
(cherry picked from commit 9c61fdc)

# Conflicts:
#	build.sbt
#	src/main/scala/chisel3/ltl/LTL.scala
@mergify mergify bot mentioned this pull request Jul 2, 2024
Merged
14 tasks
chiselbot pushed a commit that referenced this pull request Jul 9, 2024
@mergify @dobios @jackkoenig
[LTL] Deprecate disable intrinsic (backport #4237) (#4239)
d4c0050 
* [LTL] Deprecate disable intrinsic (#4237)

(cherry picked from commit 9c61fdc)

# Conflicts:
#	build.sbt
#	src/main/scala/chisel3/ltl/LTL.scala

* Resolve backport conflicts

---------

Co-authored-by: Amelia Dobis <amelia.dobis@sifive.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Deprecation Deprecates an API, will be included in release notes
Projects
None yet
Milestone
6.x
Development

Successfully merging this pull request may close these issues.
2 participants
@dobios @jackkoenig